✅ Deploy Preview for eks-workshop ready!

Name	Link
🔨 Latest commit	ac52fb3
🔍 Latest deploy log	https://app.netlify.com/sites/eks-workshop/deploys/658613f2dec2420008d5c983
😎 Deploy Preview	https://deploy-preview-709--eks-workshop.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

I think the logging logic probably needs to be more complex than this. If we want to be able to implement something that tells the user when a command failed and which log file there will need to be something that catches the error since set -e will exit. Also, it looks like this is redirecting stdout as well is that correct?

Also, it looks like this is redirecting stdout as well is that correct?

This will capture (in the log) and display both stdout and stderr. Since we have set -e, in the observability I added the || true since we know the error is possible.

I didn't change the logic, except we have that log file of the last action that trigged the problem the issue will see (but it still could be caused by a previous call)

Oh yeah, forgot its tee.

What I mean by the logic is that in the script that curls reset-environment, runs and it and uses tee ideally we would catch any error that happens in the reset-environment run and message the user to refer to appropriate log file by exact path.

For example

$ prepare-environment mymodule
[...]
An error occurred, please contact your workshop proctor or raise an issue at https://github.com/aws-samples/eks-workshop-v2/issues
Log file can be found at /eks-workshop/logs/action[...].log

Oh yeah, forgot its tee.

What I mean by the logic is that in the script that curls reset-environment, runs and it and uses tee ideally we would catch any error that happens in the reset-environment run and message the user to refer to appropriate log file by exact path.

For example

$ prepare-environment mymodule
[...]
An error occurred, please contact your workshop proctor or raise an issue at https://github.com/aws-samples/eks-workshop-v2/issues
Log file can be found at /eks-workshop/logs/action[...].log

Have a look at the latest PR, this should be pretty similar to your suggestions

hi team, what are we missing to continue merging this pull request? happy to help!

I've removed the logging feature from this PR for now so we can get the basic fix merged.